GNOME Bugzilla – Bug 790950
codec-utils: add some missing gi annotations
Last modified: 2017-11-30 09:29:37 UTC
codec-utils is missing some GI annotations. Mostly for 'out' and 'array' type parameters
Created attachment 364582 [details] [review] codec-utils: add some missing gi annotations Missing some array and out parameters annotations
Comment on attachment 364582 [details] [review] codec-utils: add some missing gi annotations The Opus (array) ones will need a length somewhere to be usable from bindings
There is a fixed-size that can be used for the ones that use channel_mapping[256] but some are just const guint8* arrays. Not sure what to do about those.
Are they the same length as one of the channel parameters?
Created attachment 364598 [details] [review] codec-utils: add some missing gi annotations They are all based on the number of channels
Review of attachment 364598 [details] [review]: I think this is also not ideal. It means that the channels argument disappears, and IIRC the array can be optional while the channels are not?
Created attachment 364654 [details] [review] codec-utils: add some missing gi annotations You're right. I can't think on a way to make this work for those functions without improving gobject-introspection to have a new tag for this scenario. For now, I guess we can still have these improvements merged so that the other functions work.
Comment on attachment 364654 [details] [review] codec-utils: add some missing gi annotations Yes, go for it. Whatever we do is suboptimal, but at least improves on the current situation.
commit 17e1e308a3a9488f6b30322f27a37200b0485640 Author: Thiago Santos <thiagossantos@gmail.com> Date: Tue Nov 28 09:33:11 2017 -0800 codec-utils: add some missing gi annotations Missing some array and out parameters annotations https://bugzilla.gnome.org/show_bug.cgi?id=790950