After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790923 - Drop the old shell code
Drop the old shell code
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-28 01:32 UTC by Georges Basile Stavracas Neto
Modified: 2017-11-28 19:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
project: Drop the old shell (54.03 KB, patch)
2017-11-28 01:32 UTC, Georges Basile Stavracas Neto
committed Details | Review
shell-model: Remove old categories (12.77 KB, patch)
2017-11-28 01:32 UTC, Georges Basile Stavracas Neto
committed Details | Review
project: Remove CcInfoPanel (22.05 KB, patch)
2017-11-28 01:32 UTC, Georges Basile Stavracas Neto
committed Details | Review
shell-model: Remove hidden category (1.86 KB, patch)
2017-11-28 01:32 UTC, Georges Basile Stavracas Neto
committed Details | Review

Description Georges Basile Stavracas Neto 2017-11-28 01:32:32 UTC
We're not shipping it anymore, and it can be safely dropped.
Comment 1 Georges Basile Stavracas Neto 2017-11-28 01:32:37 UTC
Created attachment 364536 [details] [review]
project: Drop the old shell

This is not used anymore, and is only consuming compile
time now.
Comment 2 Georges Basile Stavracas Neto 2017-11-28 01:32:42 UTC
Created attachment 364537 [details] [review]
shell-model: Remove old categories

Since we don't maintain two different shells anymore, there
is no need to maintain the two different sets of categories
in the desktop files.

This commit also drops the "#ifdef CC_ENABLE_ALT_CATEGORIES"
blocks, since the previous commit removed that define.
Comment 3 Georges Basile Stavracas Neto 2017-11-28 01:32:48 UTC
Created attachment 364538 [details] [review]
project: Remove CcInfoPanel

This panel was hidden in the new shell, and now that
we don't have the old one, can be safely dropped.

Minor adjustments were made to the other panels to
properly remove this panel.
Comment 4 Georges Basile Stavracas Neto 2017-11-28 01:32:54 UTC
Created attachment 364539 [details] [review]
shell-model: Remove hidden category

No more panels are hidden now.
Comment 5 Rui Matos 2017-11-28 17:43:13 UTC
Review of attachment 364536 [details] [review]:

++
Comment 6 Rui Matos 2017-11-28 17:43:25 UTC
Review of attachment 364537 [details] [review]:

seems fine
Comment 7 Rui Matos 2017-11-28 17:44:05 UTC
Review of attachment 364538 [details] [review]:

lgtm
Comment 8 Rui Matos 2017-11-28 17:44:43 UTC
Review of attachment 364539 [details] [review]:

otherwise fine

::: shell/cc-panel-loader.c
@@ +190,3 @@
        * that are only visible in the new Shell.
        */
+      cc_shell_model_add_item (model, category, G_APP_INFO (app), all_panels[i].name);

the comment above should go too
Comment 9 Georges Basile Stavracas Neto 2017-11-28 19:06:34 UTC
Thanks for the review. Fixed the last commit as suggested.

Attachment 364536 [details] pushed as 34f1acd - project: Drop the old shell
Attachment 364537 [details] pushed as b23ef59 - shell-model: Remove old categories
Attachment 364538 [details] pushed as 6123d97 - project: Remove CcInfoPanel
Attachment 364539 [details] pushed as c13de50 - shell-model: Remove hidden category