After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790902 - writes window state settings on each configure event
writes window state settings on each configure event
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2017-11-27 14:11 UTC by Christian Persch
Modified: 2018-01-23 19:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Christian Persch 2017-11-27 14:11:29 UTC 
Steps to repro:
0) Watch for dconf updates (e.g. $ dconf watch /, or see the dconf db coming up in fatrace)
1) Open develp
2) Switch away from and back to the workspace devhelp is on
3) See that each of these caused a re-write of the dconf database, and wakeup of each other process using dconf to re-open the db

Reason:
dh-window updates the width, height, x/y position and maximised setting on idle after each configure event.

At a minimum, devhelp should first check if the value has changed before storing the setting again; but IMHO it should only store these on exit, not on each configure event.
Comment 1 Sébastien Wilmet 2017-12-08 10:49:33 UTC 
This was even worse before, it has been improved recently in bug #786008 (fixed in >= 3.26).

I've added a FIXME comment, see:
commit d170ad73f94cdb0a946820afd0e6d591654730d5
Comment 2 Sébastien Wilmet 2018-01-10 11:53:01 UTC 
In bug #786008 it was only done for DhWindow, not DhAssistant. When fixing this bug, DhAssistant should not be forgotten.
Comment 3 Sébastien Wilmet 2018-01-23 19:18:15 UTC 
Fixed:
commit fff07126c457a84fcdc64da6f9a386c033ba5426
commit 0c08e672c2c39d07d531ba7888847de2cfd9a5ae