After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790886 - Improve Meson builds on Visual Studio
Improve Meson builds on Visual Studio
Status: RESOLVED FIXED
Product: glib-openssl
Classification: Other
Component: general
2.50.x
Other Windows
: Normal normal
: ---
Assigned To: glib-openssl Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-27 07:23 UTC by Fan, Chun-wei
Modified: 2017-11-27 08:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meson: Improve Visual Studio build experience (4.15 KB, patch)
2017-11-27 07:39 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2017-11-27 07:23:18 UTC 
Hi,

There are now Meson build files for building glib-openssl, but then because the OpenSSL build system for Visual Studio does not generate the pkg-config (or so) files for us, we need to detect the OpenSSL installation by hand, using cc.has_header() and cc.has_library(), when we can't find the pkg-config files on Visual Studio builds.

Also, we could simplify things a little bit as we could just force-include (/FI) the msvc_recommended_pragmas.h header file that comes with GLib, so that we can silence warnings that don't matter that much and bail our on warnings that can really raise concern.

With blessing, thank you!
Comment 1 Fan, Chun-wei 2017-11-27 07:39:15 UTC 
Created attachment 364481 [details] [review]
meson: Improve Visual Studio build experience

Hi,

This is the patch to meson.build that aims to improve the build experience on Visual Studio.

With blessings, thank you!
Comment 2 Ignacio Casal Quinteiro (nacho) 2017-11-27 08:20:11 UTC 
Review of attachment 364481 [details] [review]:

Thanks for the patches, they look good to me and I can finally remove the hand-made openssl pc files from gvsbuild
Comment 3 Fan, Chun-wei 2017-11-27 08:47:24 UTC 
Review of attachment 364481 [details] [review]:

Hi Nacho,

Thanks for the fast review, I have pushed the patch as d36e23e.

With blessings, thank you!