After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790834 - Fix eslint not showing any warning
Fix eslint not showing any warning
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-26 00:23 UTC by Giovanni Campagna
Modified: 2017-11-26 02:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
eslint: Don't crash if eslint message does not contain a line (1.11 KB, patch)
2017-11-26 00:23 UTC, Giovanni Campagna 		committed Details | Review
eslint: tell eslint not to ignore files in node_modules/* (1.35 KB, patch)
2017-11-26 00:23 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2017-11-26 00:23:40 UTC 
If you edit a JS file in node_modules/* (eg a library that's bundled with
your project), the eslint plugin crashes because eslint returns a fatal
message indicating that the file is ignored.
Comment 1 Giovanni Campagna 2017-11-26 00:23:42 UTC 
Created attachment 364398 [details] [review]
eslint: Don't crash if eslint message does not contain a line

Just skip the message and process the rest of the output
Comment 2 Giovanni Campagna 2017-11-26 00:23:45 UTC 
Created attachment 364399 [details] [review]
eslint: tell eslint not to ignore files in node_modules/*

eslint "helpfully" ignores all files in node_modules/* and
bower_components/* by default (even if --no-ignore is passed).

This is fine for command line usage, but in Builder, assume
that if the user opens a file, they really want diagnostics
for that file, regardless of its location.
Comment 3 Christian Hergert 2017-11-26 01:17:06 UTC 
Review of attachment 364398 [details] [review]:

LGTM
Comment 4 Christian Hergert 2017-11-26 01:18:00 UTC 
Review of attachment 364399 [details] [review]:

Seems reasonable to me
Comment 5 Giovanni Campagna 2017-11-26 02:23:57 UTC 
Thanks for the review, pushed!