GNOME Bugzilla – Bug 790819
Change sync timestamps to integers
Last modified: 2018-01-31 19:05:29 UTC
Should've done this from the beginning, there is no much point to have timestamps as doubles.
Created attachment 364592 [details] [review] sync: Migrate timestamps to gint64
Review of attachment 364592 [details] [review]: Looks like I missed this, sorry. I haven't looked over it closely, but it looks sane.
I trust that, before deciding to backport this, you've considered the risk of breaking something right before releasing 3.26.4 (which only you can assess), relative to the cost of having separate data types for timestamps between gnome-3-26 and master (which I suppose is probably a fairly high cost).
This patch changes the format string of the GVariant used to load/save bookmarks to file. So applying it only on master, and not on gnome-3-26 too, would be problematic when you run Ephy on gnome-3-26 after you've run it on master and the migration happened, because bookmarks won't be loaded: GLib-CRITICAL **: 21:28:49.317: the GVariant format string '(x&s&sdbas)' has a type of '(xssdbas)' but the given value has a type of '(xssxbas)'. Since we switch often between running Ephy from master and from 3.26, that's why I wanted this to land in both of them at the same time. Moreover, I don't see anything that can get broken by this change, sync and all other components should work the same, so I'd say that we're safe to do it.
Attachment 364592 [details] pushed as 89a3e1e - sync: Migrate timestamps to gint64
(In reply to Gabriel Ivașcu from comment #4) > This patch changes the format string of the GVariant used to load/save > bookmarks to file. So applying it only on master, and not on gnome-3-26 too, > would be problematic when you run Ephy on gnome-3-26 after you've run it on > master and the migration happened, because bookmarks won't be loaded: > GLib-CRITICAL **: 21:28:49.317: the GVariant format string '(x&s&sdbas)' has > a type of '(xssdbas)' but the given value has a type of '(xssxbas)'. Since > we switch often between running Ephy from master and from 3.26, that's why I > wanted this to land in both of them at the same time. > > Moreover, I don't see anything that can get broken by this change, sync and > all other components should work the same, so I'd say that we're safe to do > it. It caused bug #792683, which has resulted in at least two users losing all their bookmarks. Lesson learned....