After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790814 - search-toolbar: Simplify handling search
search-toolbar: Simplify handling search
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
: 790813 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-11-25 07:27 UTC by Mohammed Sadiq
Modified: 2017-12-01 11:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
search-toolbar: Simplify handling search (3.85 KB, patch)
2017-11-25 07:28 UTC, Mohammed Sadiq 		committed Details | Review

Description Mohammed Sadiq 2017-11-25 07:27:58 UTC 
.
Comment 1 Mohammed Sadiq 2017-11-25 07:28:53 UTC 
Created attachment 364381 [details] [review]
search-toolbar: Simplify handling search

Search was handled by connecting to "inserted-text" and
"deleted-text" signals of the associated GtkEntryBuffer of the
search entry.

Instead, hook to change in "text" property of the GtkEntry.
Also, remove the GtkEntryBuffer variable as we no longer use that.
Comment 2 Mohammed Sadiq 2017-11-25 08:28:38 UTC 
*** Bug 790813 has been marked as a duplicate of this bug. ***
Comment 3 Isaque Galdino 2017-12-01 11:03:58 UTC 
Review of attachment 364381 [details] [review]:

Pushed to master. Nice work! Thanks.