After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790792 - display: Show insensitive apply button for invalid configurations
display: Show insensitive apply button for invalid configurations
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-24 14:42 UTC by Benjamin Berg
Modified: 2018-03-29 10:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
display: Show insensitive apply button for invalid configurations (6.49 KB, patch)
2017-11-24 14:42 UTC, Benjamin Berg 		committed Details | Review
Screenshot showing it in action (303.37 KB, image/png)
2017-11-24 17:42 UTC, Benjamin Berg 		  Details

Description Benjamin Berg 2017-11-24 14:42:50 UTC 
When the user creates temporary invalid configurations the dialog used
to hide the apply button as if no change had been done so far. Change
this to show the normal "Apply"/"Cancel" titlebar but make the "Apply"
button insensitive and add a symbolic warning icon with an explanation.

Unfortunately we don't see to get the reason in a way that we could
translate it, so the explanation is static suggestion some possible
reasons (monitors not adjacent/overlaping and hardware limitations).
Comment 1 Benjamin Berg 2017-11-24 14:42:56 UTC 
Created attachment 364333 [details] [review]
display: Show insensitive apply button for invalid configurations
Comment 2 Rui Matos 2017-11-24 16:39:01 UTC 
Review of attachment 364333 [details] [review]:

Code looks fine, thanks. It would be nice if you could post a screenshot of how it looks so we can get some design input
Comment 3 Benjamin Berg 2017-11-24 17:42:26 UTC 
Created attachment 364349 [details]
Screenshot showing it in action

Note that this runs with the patches from bug #786971. Otherwise it is near-impossible to hit an invalid configuration.
Comment 4 Benjamin Berg 2018-02-01 09:51:42 UTC 
Allan has added a note to

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/system-settings/displays/displays-v4.png

The idea is to only change the title/subtitle rather than adding any further warning indicators.
Comment 5 Benjamin Berg 2018-03-29 10:11:49 UTC 
Attachment 364333 [details] pushed as adf5a42 - display: Show insensitive apply button for invalid configurations