Created attachment 364256 [details] [review]
import-dialog: Rewrite logic and port to GtkBuilder

* Port to GtkBuilder xml ui definitions
* Create locations list only when asked for one.

Created attachment 364257 [details] [review]
import-dialog: Rewrite logic and port to GtkBuilder

* Port to GtkBuilder xml ui definitions
* Create locations list only when asked for one.

Review of attachment 364257 [details] [review]:

This piece of code I believe isn't related to this change, right?
diff --git a/src/bjb-app-menu.c b/src/bjb-app-menu.c
index dff6324..17f99c0 100644
--- a/src/bjb-app-menu.c
+++ b/src/bjb-app-menu.c
@@ -79,7 +79,7 @@ external_activated (GSimpleAction *action,
       g_free (uri);
     }
 
-    g_list_free (locations);
+    g_list_free_full (locations, g_free);
   }
 
   if (dialog)

(In reply to Isaque Galdino from comment #3)
> Review of attachment 364257 [details] [review] [review]:
> 
> This piece of code I believe isn't related to this change, right?
> -    g_list_free (locations);
> +    g_list_free_full (locations, g_free);
>    }

Isn't it? a list is transferred from the function (in import-dialog), which should be freed fully (not just the container as it was).

Or should I do this in a separate commit?

(In reply to Mohammed Sadiq from comment #4)
> Or should I do this in a separate commit?

Ok, let's keep it in this commit then.

Created attachment 364738 [details]
Window resizing

I believe you need to fix the resize of the window. I don't think we should leave user to resize it to be that tall.

Created attachment 364742 [details] [review]
import-dialog: Rewrite logic and port to GtkBuilder

* Port to GtkBuilder xml ui definitions
* Create locations list only when asked for one.

The dialog is no loneger user resizable.

Review of attachment 364742 [details] [review]:

Good!