After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790738 - DzlSuggestionEntry pops up if you switch to a new tab and then back
DzlSuggestionEntry pops up if you switch to a new tab and then back
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 790732
 
 
Reported: 2017-11-22 23:32 UTC by Michael Catanzaro
Modified: 2018-06-24 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Catanzaro 2017-11-22 23:32:50 UTC 
The entry pops up if you switch to a new tab and then back, while the entry was already open in the previous tab. That's disturbing. It should not do that!
Comment 1 Jan-Michael Brummer 2018-06-24 08:51:10 UTC 
Issue is caused by libdazzle as it only has a changed callback. Within this cb the only guard around showing suggestion box is whether it has focus.

Switching tabs within notebooks sets the entry text while keeping the focus, that's why a suggestion box is shown.
GtkEntry avoids this behaviour by explicit blocking completion during set_text operation. Unfortunately there is no such function in libdazzle yet.

Proposal: Extend libdazzles api with a set_text function blocking suggestion box.
Comment 2 Michael Catanzaro 2018-06-24 14:17:00 UTC 
(In reply to Jan-Michael Brummer from comment #1)
> Proposal: Extend libdazzles api with a set_text function blocking suggestion
> box.

Thanks for working on this. Please talk to Christian Hergert about the API request.
Comment 3 Christian Hergert 2018-06-24 18:27:37 UTC 
Seems reasonable. Let me know if https://gitlab.gnome.org/GNOME/libdazzle/commit/ee1cde831d7bae7551890ca6ec0b12006f2537e7 is enough for your use case.

I'd like to avoid adding a set_text() API because it would break with GtkEntry:text usage.
Comment 4 Jan-Michael Brummer 2018-06-24 19:12:19 UTC 
It's working fine now. This use case is fixed.
Comment 5 Michael Catanzaro 2018-06-24 19:13:10 UTC 
Yay!