After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790695 - operations/common/exp-combine: Plug leaks in error path
operations/common/exp-combine: Plug leaks in error path
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: operations
git master
Other All
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2017-11-22 07:17 UTC by Debarshi Ray
Modified: 2017-11-24 15:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
operations/common/exp-combine: Plug leaks in error path (928 bytes, patch)
2017-11-22 07:22 UTC, Debarshi Ray 		committed Details | Review
operations/common/exp-combine: Simplify code (1.43 KB, patch)
2017-11-22 07:22 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-11-22 07:17:35 UTC 
Ell spotted some more leaks while discussing bug 790675.
Comment 1 Debarshi Ray 2017-11-22 07:22:02 UTC 
Created attachment 364167 [details] [review]
operations/common/exp-combine: Plug leaks in error path
Comment 2 Debarshi Ray 2017-11-22 07:22:30 UTC 
Created attachment 364168 [details] [review]
operations/common/exp-combine: Simplify code
Comment 3 Debarshi Ray 2017-11-24 15:41:57 UTC 
From #gegl on GIMPNet:

15:04 <rishi> pippin: Ell: Does this look OK:                                   
      https://bugzilla.gnome.org/show_bug.cgi?id=790695 ? Hacked up in hurry    
      with sleepy eyes, so please double check.
15:23 <Ell> rishi: yep, looks good :)


commit c817c5fab306cec7235324ad07931ccf539a7ad1
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Wed Nov 22 08:15:20 2017 +0100

    operations/common/exp-combine: Simplify code
    
    https://bugzilla.gnome.org/show_bug.cgi?id=790695

commit 5dc18853ba8999a66b6d11fe9227fb6c341c0c84
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Wed Nov 22 08:06:19 2017 +0100

    operations/common/exp-combine: Plug leaks in error path
    
    Spotted by Ell.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=790695