After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790663 - Jobs button resizes in a weird way
Jobs button resizes in a weird way
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Printers
git master
Other Linux
: Normal normal
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-21 13:32 UTC by Felipe Borges
Modified: 2017-11-21 16:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
printers: Set default text and sensitivity for the Jobs button (1.17 KB, patch)
2017-11-21 13:32 UTC, Felipe Borges 		committed Details | Review

Description Felipe Borges 2017-11-21 13:32:14 UTC 
Every single time that there is an update in the printer list, the buttons get resized when updating their labels.

By setting the "No Active Jobs" string as default we can make sure that the maximum size it gets is allocated at the opening of the panel.
Comment 1 Felipe Borges 2017-11-21 13:32:33 UTC 
Created attachment 364117 [details] [review]
printers: Set default text and sensitivity for the Jobs button

This way we make sure that the right size is allocated at the
creation time and no undesirable resizes occur after a refresh.
Comment 2 Marek Kašík 2017-11-21 15:38:28 UTC 
Review of attachment 364117 [details] [review]:

Thank you for the patch! It fixes the issue for me. Since it just reuses already available string, push it also to gnome-3-26 branch please.
Comment 3 Felipe Borges 2017-11-21 16:13:42 UTC 
Attachment 364117 [details] pushed as cfde7db (gnome-3-26) - printers: Set default text and sensitivity for the Jobs button
Attachment 364117 [details] pushed as fb43d37 (master) - printers: Set default text and sensitivity for the Jobs button