After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790655 - [review] some rework of secrets handling in core and applet
[review] some rework of secrets handling in core and applet
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-11-21 08:56 UTC by Thomas Haller
Modified: 2017-11-23 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2017-11-21 08:56:25 UTC 
Please review
Comment 1 Thomas Haller 2017-11-21 08:58:53 UTC 
core:   th/vpn-secrets-bgo790655
applet: th/vpn-secrets-bgo790655

The handling of secret request is not unified, that is applet, gnome-shell and nmcli/nmtui implement them differently. Same for the interaction with the auth-dialog.

Eventually, this should be unified by providing a convenient API from libnm.


Just a small step to that direction. Please review
Comment 2 Beniamino Galvani 2017-11-23 09:59:13 UTC 
> clients: some cleanup of requesting VPN secrets

        while (p && p->name) {
+               g_print (">>> request %s = %s\n", p->name, p->ui_name);

Remove this.

The rest LGTM.