After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790534 - Old FSF addresses used in headers
Old FSF addresses used in headers
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: General
GIT
Other Linux
: Normal minor
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2017-11-18 13:19 UTC by Anders Jonsson
Modified: 2017-12-07 20:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Replace old FSF addresses with hyperlink (7.96 KB, patch)
2017-11-18 13:19 UTC, Anders Jonsson
committed Details | Review

Description Anders Jonsson 2017-11-18 13:19:18 UTC
Created attachment 363973 [details] [review]
Replace old FSF addresses with hyperlink

Hi,
I noticed that old postal addresses to FSF are used in some file headers of goffice.

This patch replaces these old addresses with hyperlinks to <https://www.gnu.org/licenses/>.
Comment 1 Morten Welinder 2017-12-07 18:38:27 UTC
Review of attachment 363973 [details] [review]:

Looks good
Comment 2 Morten Welinder 2017-12-07 18:47:48 UTC
And if you have this automated, it would be nice if you could do libgsf too.
Comment 3 Anders Jonsson 2017-12-07 20:05:43 UTC
(In reply to Morten Welinder from comment #1)
> Review of attachment 363973 [details] [review] [review]:
> 
> Looks good

Thanks for the review. Committed as Commit 	275ad7c73737dd2194e800cc80f9c91fda29e4ea

I do the changes semi-automatically with perl regexes. I took a look at libgsf, but it uses the current postal address, so there's no need to change it, unless the FSF move their office again.