After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790493 - vaapi should eglGetPlatformDisplay to eglGetDisplay
vaapi should eglGetPlatformDisplay to eglGetDisplay
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-17 12:08 UTC by Michael Olbrich
Modified: 2018-01-16 18:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libs: egl: utils: use eglGetPlatformDisplay() (6.43 KB, patch)
2018-01-12 12:02 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Michael Olbrich 2017-11-17 12:08:44 UTC 
eglGetDisplay() is currently broken in mesa[1] for wayland.
Using eglGetDisplay() is rather fragile anyway ant it is recommended to use eglGetPlatformDisplay() instead if possible.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=103757
Comment 1 Matthew Waters (ystreet00) 2017-11-17 12:14:24 UTC 
Oh look! a helper! :)

https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/gst-libs/gst/gl/egl/gstgldisplay_egl.c#n99
Comment 2 Víctor Manuel Jáquez Leal 2018-01-12 12:02:02 UTC 
Created attachment 366725 [details] [review]
libs: egl: utils: use eglGetPlatformDisplay()

eglGetDisplay() is currently broken in Mesa for Wayland.  Also using
eglGetDisplay() is rather fragile, and it is recommended to use
eglGetPlatformDisplay() when possible.

In order to do that, this patch uses the helper in GstGL. If
gstreamer-vaapi is not compiled with GstGL support, eglGetDisplay()
will be used.
Comment 3 Víctor Manuel Jáquez Leal 2018-01-16 18:05:13 UTC 
Attachment 366725 [details] pushed as 7e05160 - libs: egl: utils: use eglGetPlatformDisplay()