GNOME Bugzilla – Bug 790490
Add support for renamed options in gnome-session
Last modified: 2017-11-27 09:58:26 UTC
Created attachment 363907 [details] [review] gnome-session: Use new configure script The options in gnome-session have been renamed following the new meson porting guidelines. This patch uses a modified configure script to support such options. This patch should be applied after the rename patch is merged[0]. [0] https://bugzilla.gnome.org/attachment.cgi?id=363900
Just as a side comment, all the options/features are false by default, so gnome-session is not fully tested. It would be nice to enable at least some options to check their support.
Review of attachment 363907 [details] [review]: Is there any reason why the patch to add a configure file to those repos can't be the same for all the different modules? Can you please re-add the configure options I dropped in the initial support as well?
Created attachment 363967 [details] [review] gnome-session: Use new configure script (In reply to Bastien Nocera from comment #2) > Review of attachment 363907 [details] [review] [review]: > > Is there any reason why the patch to add a configure file to those repos > can't be the same for all the different modules? I used the Emmanuelles' script though slightly modified. I used an associative array to hold all the available options. The reason behind this modification is to avoid writing every possible option manually, which can be error prone (at least for me). Actually, there are different configure scripts in use, however they might dissapear in the future once gnome-continuous starts working with meson natively[0]. > Can you please re-add the configure options I dropped in the initial support > as well? I noticed that I made a mistake with gnome-session's default values. I've reopened the bug with the meson improvements[1] and posted a new patch[2]. Based on that patch, this patch disables docbook and man generation options, which are enabled by default by gnome-session. ConsoleKit support and Session Selection support are disabled. [0] https://bugzilla.gnome.org/show_bug.cgi?id=789146#c3 [1] https://bugzilla.gnome.org/show_bug.cgi?id=790486 [2] https://bugzilla.gnome.org/attachment.cgi?id=363966
(In reply to Iñigo Martínez from comment #3) > Created attachment 363967 [details] [review] [review] > gnome-session: Use new configure script > > (In reply to Bastien Nocera from comment #2) > > Review of attachment 363907 [details] [review] [review] [review]: > > > > Is there any reason why the patch to add a configure file to those repos > > can't be the same for all the different modules? > > I used the Emmanuelles' script though slightly modified. I used an > associative array to hold all the available options. The reason behind this > modification is to avoid writing every possible option manually, which can > be error prone (at least for me). I don't really see why we need to have as many copies of a helper script as we have modules. If the continuous maintainers are happy with that... > Actually, there are different configure scripts in use, however they might > dissapear in the future once gnome-continuous starts working with meson > natively[0]. That's not what link [0] says. It says that gnome-continuous would be replaced by something else.
Comment on attachment 363967 [details] [review] gnome-session: Use new configure script Pushed as 717e0ca - gnome-session: Use new configure script I'm sorry, but after gnome-continuous build breakage[0] due to the last gnome-session[1] patch, I've decided to push this patch (which nobody has accepted). Please, let me know if I should revert or change it. [0] http://build.gnome.org/continuous/buildmaster/builds/2017/11/27/13/build/log-gnome-session.txt [1] https://git.gnome.org/browse/gnome-session/commit/?id=f62989f1