After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790480 - Fix many typos
Fix many typos
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2017-11-17 07:48 UTC by Richard B. Kreckel
Modified: 2017-11-17 14:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (32.21 KB, patch)
2017-11-17 07:48 UTC, Richard B. Kreckel
none Details | Review
patch produced with git format-patch (35.31 KB, patch)
2017-11-17 08:37 UTC, Richard B. Kreckel
none Details | Review

Description Richard B. Kreckel 2017-11-17 07:48:08 UTC
Created attachment 363887 [details] [review]
patch

The attached patch fixes many typos in GEGL source code comments.
Comment 1 Debarshi Ray 2017-11-17 08:26:16 UTC
Review of attachment 363887 [details] [review]:

Thanks for your patch. Could you please create the patch using "git format-patch" with a proper name and email address to which it can be attributed?

Otherwise it looks good to me, but I am not a maintainer.
Comment 2 Richard B. Kreckel 2017-11-17 08:37:25 UTC
Created attachment 363895 [details] [review]
patch produced with git format-patch
Comment 3 Øyvind Kolås (pippin) 2017-11-17 14:12:40 UTC
Pushed, but I edited the patch to remove the changes to the poly2tri files, this is an external library with a copy inside GEGL. Even if we haven't seen any updates or syncs with upstream; modifying it would make integerating upstream changes harder.

commit a2c89719c903b56389c0da4a9bbd25caae0f52b1
Author: Richard Kreckel <kreckel@in.terlu.de>
Date:   Fri Nov 17 09:33:45 2017 +0100

    Fix many typos in source code comments.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=790480