After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790454 - Update README.md with new compiling instruction
Update README.md with new compiling instruction
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: retro-gtk
unspecified
Other All
: Normal minor
: ---
Assigned To: GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-16 17:05 UTC by Rouby Pierre-Antoine
Modified: 2017-12-07 11:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Update README.md compiling instruction (796 bytes, patch)
2017-11-16 17:05 UTC, Rouby Pierre-Antoine 		none Details | Review
[PATCH] README.md update compiling instruction (812 bytes, patch)
2017-11-27 10:48 UTC, Rouby Pierre-Antoine 		committed Details | Review

Description Rouby Pierre-Antoine 2017-11-16 17:05:56 UTC 
Created attachment 363851 [details] [review]
[PATCH] Update README.md compiling instruction

Hello,
When I tryed to build retro-gtk I saw the compiling instructions changed since the last modifications of README.md.
So I removed the "autotools" paragraph and added "meson" and "ninja" instructions instead.
br
Comment 1 Cyril Roelandt 2017-11-22 23:02:13 UTC 
Review of attachment 363851 [details] [review]:

::: README.md
@@ -25,3 @@
-Then compile:
-`./configure`
-`make`

I think you could keep this part and just run "ninja" instead of "make".
Comment 2 Rouby Pierre-Antoine 2017-11-27 10:48:58 UTC 
Created attachment 364487 [details] [review]
[PATCH] README.md update compiling instruction
Comment 3 Adrien Plazas 2017-12-07 11:03:24 UTC 
Sorry for the late review and thanks for the patch, it's good. :)