After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790442 - Old FSF address used in headers
Old FSF address used in headers
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
git master
Other Linux
: Normal minor
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2017-11-16 12:33 UTC by Anders Jonsson
Modified: 2017-11-17 00:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Replace old FSF addresses with hyperlink (119.33 KB, patch)
2017-11-16 12:33 UTC, Anders Jonsson
none Details | Review

Description Anders Jonsson 2017-11-16 12:33:14 UTC
Created attachment 363828 [details] [review]
Replace old FSF addresses with hyperlink

Hi,
I noticed that old addresses to FSF are used in the file headers of gnumeric.

This patch replaces these old addresses with hyperlinks.
Comment 1 Morten Welinder 2017-11-16 12:42:18 UTC
Interesting.  However, I note that the link you use is
different from the one used at https://www.gnu.org/licenses/gpl-3.0.en.html
("http" vs" https".)

Other than that, go ahead and commit.
Comment 2 Anders Jonsson 2017-11-16 13:01:55 UTC
(In reply to Morten Welinder from comment #1)
> Interesting.  However, I note that the link you use is
> different from the one used at https://www.gnu.org/licenses/gpl-3.0.en.html
> ("http" vs" https".)
> 
> Other than that, go ahead and commit.

Good point. I was looking at https://www.gnu.org/licenses/gpl-howto.html that uses http, but I'll send them an e-mail that they can consider changing to https on that page as well.

Will change to https before I commit.
Comment 3 Anders Jonsson 2017-11-16 21:22:14 UTC
(In reply to Morten Welinder from comment #1)
> Other than that, go ahead and commit.

Thanks for the review. The "https" version is now committed as Commit 30ebc8f79b5ad767bb5afc9a7740e3827cb48bdb
Comment 4 Andreas J. Guelzow 2017-11-16 23:22:24 UTC
Why does this commit touch 194 files???
Comment 5 Andreas J. Guelzow 2017-11-16 23:24:39 UTC
but did not change the URLs it was claiming to change?
Comment 6 Morten Welinder 2017-11-16 23:40:13 UTC
Looks fine to me:

--- a/component/gnumeric.c
+++ b/component/gnumeric.c
@@ -18,9 +18,7 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
- * USA
+ * along with this program; if not, see <https://www.gnu.org/licenses/>
  */
Comment 7 Andreas J. Guelzow 2017-11-17 00:04:53 UTC
Ahh yes. I was thinking of a different bug.