After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790395 - Missing schema
Missing schema
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: gnome-chess-maint
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2017-11-15 18:47 UTC by Ken VanDine
Modified: 2017-11-15 19:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Install schema file (1.30 KB, patch)
2017-11-15 18:47 UTC, Ken VanDine
none Details | Review
Install schema file (1.30 KB, patch)
2017-11-15 19:14 UTC, Ken VanDine
needs-work Details | Review
Install the svg files for the pieces in the correct location (738 bytes, patch)
2017-11-15 19:14 UTC, Ken VanDine
accepted-commit_now Details | Review
Install schema file (679 bytes, patch)
2017-11-15 19:19 UTC, Ken VanDine
accepted-commit_now Details | Review

Description Ken VanDine 2017-11-15 18:47:54 UTC
The meson build is not installing the schema
Comment 1 Ken VanDine 2017-11-15 18:47:57 UTC
Created attachment 363737 [details] [review]
Install schema file
Comment 2 Michael Catanzaro 2017-11-15 19:07:05 UTC
Review of attachment 363737 [details] [review]:

Thanks!

Hm... looks like the

::: data/meson.build
@@ +34,3 @@
+  install_dir: join_paths(datadir, 'glib-2.0', 'schemas')
+)
+meson.add_install_script ('meson_compile_gschema.py')

No extra space there... but also, this is already handled by meson_post_install.py. So we should not need the new python script.
Comment 3 Ken VanDine 2017-11-15 19:14:41 UTC
Created attachment 363739 [details] [review]
Install schema file
Comment 4 Ken VanDine 2017-11-15 19:14:44 UTC
Created attachment 363740 [details] [review]
Install the svg files for the pieces in the correct location
Comment 5 Ken VanDine 2017-11-15 19:19:58 UTC
Created attachment 363741 [details] [review]
Install schema file
Comment 6 Michael Catanzaro 2017-11-15 19:20:09 UTC
Review of attachment 363739 [details] [review]:

Looks like the same patch as before. Oops?
Comment 7 Michael Catanzaro 2017-11-15 19:20:54 UTC
Review of attachment 363740 [details] [review]:

OK.

::: data/meson.build
@@ +3,1 @@
 # The SVG's of the chess pieces

Should get rid of this stray apostrophe while you're at it.
Comment 8 Michael Catanzaro 2017-11-15 19:21:21 UTC
Review of attachment 363741 [details] [review]:

There we go!

Do you need me to commit them?
Comment 9 Ken VanDine 2017-11-15 19:22:38 UTC
I can commit them, thanks!