After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790387 - main: Remove GNOME_DESKTOP_SESSION_ID envvar
main: Remove GNOME_DESKTOP_SESSION_ID envvar
Product: gnome-session
Classification: Core
Component: general
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Reported: 2017-11-15 16:37 UTC by Bastien Nocera
Modified: 2018-03-13 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

main: Remove GNOME_DESKTOP_SESSION_ID envvar (1.10 KB, patch)
2017-11-15 16:37 UTC, Bastien Nocera
committed Details | Review
Revert "main: Remove GNOME_DESKTOP_SESSION_ID envvar" (2.48 KB, patch)
2018-02-12 19:42 UTC, Ray Strode [halfline]
committed Details | Review

Description Bastien Nocera 2017-11-15 16:37:23 UTC
Comment 1 Bastien Nocera 2017-11-15 16:37:27 UTC
Created attachment 363707 [details] [review]
main: Remove GNOME_DESKTOP_SESSION_ID envvar

It was re-added "for compatibility reasons" nearly 10 years ago in
commit b7c806503. There's really no need to keep this compatibility any
Comment 2 Ray Strode [halfline] 2017-11-15 18:56:12 UTC
Review of attachment 363707 [details] [review]:

one less environment variable sounds good to me.
Comment 3 Bastien Nocera 2017-11-16 14:36:05 UTC
Attachment 363707 [details] pushed as 6bf47ad - main: Remove GNOME_DESKTOP_SESSION_ID envvar
Comment 4 Ray Strode [halfline] 2018-02-12 19:42:00 UTC
Created attachment 368276 [details] [review]
Revert "main: Remove GNOME_DESKTOP_SESSION_ID envvar"

This reverts commit 6bf47ad8c6f0a513c95a5043e38ad51cc0248943.
Comment 5 Ray Strode [halfline] 2018-02-12 19:42:50 UTC
we can't do this, breaks libproxy which breaks gnome-shell:
Comment 6 Ray Strode [halfline] 2018-02-12 19:45:00 UTC
Comment on attachment 368276 [details] [review]
Revert "main: Remove GNOME_DESKTOP_SESSION_ID envvar"

committed the revert:
Comment 7 Michael Catanzaro 2018-02-13 01:32:55 UTC
(In reply to Ray Strode [halfline] from comment #5)
> we can't do this, breaks libproxy which breaks gnome-shell:

Should be half-fixed by, which will ensure that libproxy is not used by GNOME stuff (e.g. gnome-shell) when running inside GNOME. I *think* it should be safe to re-land the gnome-session commit now.

That doesn't fix the underlying problem in libproxy, which is that libproxy links to one version of mozjs, while gjs links to another version of mozjs, so the two are incompatible, and that glib will dlopening libproxy at runtime, but only when not running in GNOME to ensure developers don't notice.
Comment 8 Bastien Nocera 2018-03-13 12:26:19 UTC
Comment on attachment 363707 [details] [review]
main: Remove GNOME_DESKTOP_SESSION_ID envvar

Reset the patch status, as it's been reverted.
Comment 9 Bastien Nocera 2018-03-13 12:26:45 UTC
I'm guessing we can commit this once 3.28 has been branched?
Comment 10 Ray Strode [halfline] 2018-03-13 12:36:10 UTC
yea i believe mcatanzaro fixed it at tge other end so we should be good
Comment 11 Ray Strode [halfline] 2018-03-13 14:09:25 UTC
Attachment 363707 [details] pushed as 00e0e62 - main: Remove GNOME_DESKTOP_SESSION_ID envvar