Created attachment 363600 [details] [review]
build: Rename build options

Following the new meson porting guidelines[0], this patch renames the build options. The list of changes is as follows:

- Remove the enable prefix from boolean options.
- The character separator from multi-word options has been changed to underscore.

[0] https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting

Created attachment 363601 [details] [review]
build: Remove default warning level

gnome-bluetooth uses 1 as the project's default warning level. However, meson already uses this level as the default warning level.

This patch removes the warning level from project's default options.

Created attachment 363602 [details] [review]
build: Use meson 0.43.0 features

meson 0.43.0 comes with a new function in the compiler's object called get_supported_arguments, which allows checking multiple optiones at once.

This patch bumps meson's version number and also takes advantage of this new feature.

Created attachment 363603 [details] [review]
build: Remove unused defines

meson generates the config.h file with multiple defines to be used as guards, in the same way as autotools does. However, almost all of them are not used.

This patch removes the unused defines.

Created attachment 363604 [details] [review]
build: Improve post install script

The post install script is executing a rename process from when the icons' file names also contained their installation path, which is not necessary anymore. It also contains a fixed path for datadir, which might change.

This patch removes the unnecessary rename process and also used the provided datadir path, if the user provides one, or the default path.

Created attachment 363605 [details] [review]
build: Remove debug related variables

meson was holding a variable for the build type, and another one for checking if the build is a debug build.

This can be inspected directly, without storing it in any variable, because it's only used once.

Created attachment 363606 [details] [review]
build: Use template files for enums generations

The data contents for the enum related files were stored are stored in the build files.

This patch moves this information to template files to be used along glib-mkenums.

Created attachment 363607 [details] [review]
build: Set prefix relative install_dir for pkgconfig

While installing seems to have no issues with absolute paths for install_dir the pkgconfig integration in meson does and create wrong library paths in the .pc file.

Created attachment 363608 [details] [review]
build: Use the full path to the linker script

The symbol map represents the name of the linker script file. However, it's more useful if it holds the full paths, because it could be referenced from any build file.

Created attachment 363612 [details] [review]
build: Remove .gitignore file

meson does not allow to build source code inside the source code tree, for this reason there is no need to use .gitignore to ignore built files.

This patch removes .gitignore file which is no longer needed.

I changed the commit messages for a few of the patches, hence the
incomplete commit list below, but they've all been pushed. Thanks!

Attachment 363600 [details] pushed as b029fbe - build: Rename build options
Attachment 363601 [details] pushed as 166fda8 - build: Remove default warning level
Attachment 363602 [details] pushed as 8f36677 - build: Use meson 0.43.0 features
Attachment 363603 [details] pushed as ceb066a - build: Remove unused defines
Attachment 363605 [details] pushed as 33d1645 - build: Remove debug related variables
Attachment 363608 [details] pushed as 18a6bc1 - build: Use the full path to the linker script
Attachment 363612 [details] pushed as 029bf32 - build: Remove .gitignore file