After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790305 - Use a more convenient developers.redhat.com end-point
Use a more convenient developers.redhat.com end-point
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-11-13 19:25 UTC by Debarshi Ray
Modified: 2017-11-14 16:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Reference code to download a RHEL ISO using the new end-point (6.56 KB, text/plain)
2017-11-13 19:25 UTC, Debarshi Ray
  Details
wizard-source: Rename a variable (1.01 KB, patch)
2017-11-13 19:44 UTC, Debarshi Ray
committed Details | Review
wizard-source: Use more convenient developers.redhat.com end-point (16.33 KB, patch)
2017-11-13 19:44 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2017-11-13 19:25:45 UTC
Created attachment 363543 [details]
Reference code to download a RHEL ISO using the new end-point

A recent round of discussions with the developers.redhat.com maintainers has revealed a more convenient end-point. It will vastly simplify our code by removing the need to cache, download and parse the initial JSON or XML from the server before showing the web UI.

Instead of issuing a GET request to
  https://developers.redhat.com/download-manager/rest/available/rhel
... we need to point the WebKitWebView to
  https://developers.redhat.com/download-manager/rest/featured/file/rhel
Comment 1 Debarshi Ray 2017-11-13 19:44:32 UTC
Created attachment 363545 [details] [review]
wizard-source: Rename a variable
Comment 2 Debarshi Ray 2017-11-13 19:44:48 UTC
Created attachment 363546 [details] [review]
wizard-source: Use more convenient developers.redhat.com end-point
Comment 3 Felipe Borges 2017-11-14 14:55:54 UTC
Review of attachment 363545 [details] [review]:

ok
Comment 4 Felipe Borges 2017-11-14 14:58:47 UTC
Review of attachment 363546 [details] [review]:

I see LOC removed, I accept! :)

Thanks for working on this.

The new endpoint makes the parsing way simpler and therefore secure. lgtm
Comment 5 Debarshi Ray 2017-11-14 16:05:46 UTC
Comment on attachment 363545 [details] [review]
wizard-source: Rename a variable

Pushed to master.
Comment 6 Debarshi Ray 2017-11-14 16:05:54 UTC
Comment on attachment 363546 [details] [review]
wizard-source: Use more convenient developers.redhat.com end-point

Pushed to master.