GNOME Bugzilla – Bug 790298
vtenc: vtenc_h264 property defaults in described help text don't match actual defaults.
Last modified: 2017-11-13 18:13:23 UTC
some of the properties on vtenc_h264 are described in the output of gst-inspect-1.0 with defaults that don't match actual defaults. For example: allow-frame-reordering: Whether to allow frame reordering or not flags: readable, writable Boolean. Default: true The #define at the top of the code does in fact imply the default should be TRUE, but it isn't initialized to TRUE in the element's init function. The element is actually using FALSE as the default, because it's value is 0. Unless I'm missing something these defaults need to be configured there.
Nicely spotted. Are going to make a patch?
I was in the process of creating the patch, when I noticed something. The properties are created with the flag G_PARAM_CONSTRUCT. Which actually does the initializing. I've never used that flag (and didn't know what it does), so I didn't see where it gets initialized. Also in my testing I checked the actual values in gst_vtenc_init() function which is prior to glib's handling of G_PARAM_CONSTRUCT flag. If I move my check further into the element's code I see now that it actually works as documented. So I think this is not a bug. Sorry for wasting time.
Ah right, that would work as well (we usually don't use that flag in GStreamer). No worries, thanks for double-checking.