After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790234 - Various meson improvements
Various meson improvements
Status: RESOLVED OBSOLETE
Product: gnome-calendar
Classification: Applications
Component: General
3.23.x
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-12 09:48 UTC by Iñigo Martínez
Modified: 2017-11-24 22:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Rename build options (2.06 KB, patch)
2017-11-12 09:53 UTC, Iñigo Martínez
none Details | Review
project: Remove default warning level (943 bytes, patch)
2017-11-12 09:57 UTC, Iñigo Martínez
none Details | Review
project: Rename build options (2.06 KB, patch)
2017-11-12 09:58 UTC, Iñigo Martínez
none Details | Review
project: Remove unused defines (2.98 KB, patch)
2017-11-12 10:10 UTC, Iñigo Martínez
none Details | Review

Description Iñigo Martínez 2017-11-12 09:48:37 UTC
New meson porting guidelines[0] have been published and the list of options should be renamed.

[0] https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting
Comment 1 Iñigo Martínez 2017-11-12 09:53:07 UTC
Created attachment 363427 [details] [review]
build: Rename build options

This patch renames the build options. The list of changes is as follows:

- Remove the enable prefix from boolean options.
- The character separator from multi-word options has been changed to underscore.
Comment 2 Iñigo Martínez 2017-11-12 09:57:48 UTC
Created attachment 363428 [details] [review]
project: Remove default warning level

gnome-calendar uses `1` as the project's default warning level. However, meson already uses this level as the default warning level, so it's actually unnecessary.

This patch removes the warning level from project's default options.
Comment 3 Iñigo Martínez 2017-11-12 09:58:21 UTC
Created attachment 363429 [details] [review]
project: Rename build options

Fixed commit subject.
Comment 4 Iñigo Martínez 2017-11-12 10:10:44 UTC
Created attachment 363430 [details] [review]
project: Remove unused defines

There are a lot of defines in the `config.h` file mimicking those generated by autotools. However, most of them are not actually needed: std headers defines and functions defines.

I am used to not removed them because I'm not sure if they are necessary in non-linux systems (bsd?), or even on older linux systems. They are at least not necessary on my system.

This patch removes the correspondant checks.
Comment 5 Georges Basile Stavracas Neto 2017-11-24 22:45:45 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-calendar/issues/214.