After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790222 - Compile error with --disable-conchek / --enable-concheck=no
Compile error with --disable-conchek / --enable-concheck=no
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
1.10.x
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-11-12 01:38 UTC by nix.or.die
Modified: 2017-11-13 10:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] core: fix build without connectivity check (2.19 KB, patch)
2017-11-12 09:38 UTC, Beniamino Galvani 		none Details | Review

Description nix.or.die 2017-11-12 01:38:33 UTC 
The following compile error occurs with disabled concheck:


nm-manager.c:(.text.get_property+0x361): undefined reference to `nm_connectivity_get'
nm-manager.c:(.text.get_property+0x36a): undefined reference to `nm_connectivity_check_enabled'

Seems to be introduced by commit 4dd30b784c53e9b61b6e3a2b2e135f589747fc06


Regards
Comment 1 Beniamino Galvani 2017-11-12 09:38:51 UTC 
Created attachment 363426 [details] [review]
[PATCH] core: fix build without connectivity check
Comment 2 nix.or.die 2017-11-12 12:48:26 UTC 
I can confirm the patch fixes the error here. 

Regards
Comment 3 Thomas Haller 2017-11-13 09:23:32 UTC 
(In reply to Beniamino Galvani from comment #1)
> Created attachment 363426 [details] [review] [review]
> [PATCH] core: fix build without connectivity check

lgtm