GNOME Bugzilla – Bug 790185
Don't install appstream metadata to deprecated location
Last modified: 2018-01-01 12:44:04 UTC
/usr/share/metainfo/ has been the preferred location for appstream metadata since appstream 0.9.4 a year and a half ago (instead of /usr/share/appdata/) https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#spec-component-location If you use appstream-glib >= 0.7.3, the appstream metadata should be installed to the newer location. However, the build picks up the m4/appstream-xml.m4 from the git repo/tarball and uses that instead. Please either update the appstream-xml.m4 or consider removing it completely. Do you support building the latest shotwell on any platforms that don't have appstream-glib and autoconf-archive? Can you remove the m4/ directory completely? I imagine you'll eventually want to move to build with meson which won't use the m4/ directory anyway.
How does that match up with the links in bug 784883 ?
btw, there is something broken in the packaging. there is no (functional) difference between shotwell's m4 and the one from appstream-util. Athough I see the change you mention in https://github.com/hughsie/appstream-glib/blob/master/data/appstream-xml.m4
The patch from bug 784883 was included in shotwell 0.26.4. shotwell 0.26.4 with appstream-glib 0.7.4 installs to /usr/share/appdata/ shotwell 0.26.4 with appstream-glib 0.7.4 after removing shotwell's m4 directory installs to /usr/share/metainfo/ In your Debian/Ubuntu packaging, you would probably need to add Build-Depends on autoconf-archive, libglib2.0-dev-bin and yelp-tools. > there is no (functional) difference between shotwell's m4 and the one from appstream-util. Athough I see the change you mention in https://github.com/hughsie/appstream-glib/blob/master/data/appstream-xml.m4 That is a difference. The old appstream metadata location is a warning in the Debian lintian tool, because the appstream developers would eventually like to stop supporting the old location. https://lintian.debian.org/tags/appstream-metadata-in-legacy-location.html
No, if you look at artful, the m4 files are equivalent apart from one comment because appstream-util is still 0.7.1 (which I just noticed). I will take a look
Created attachment 366136 [details] [review] Use new location for appdata files
Attachment 366136 [details] pushed as c625d5b - Use new location for appdata files