After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790177 - Various meson related improvements
Various meson related improvements
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-11-10 16:02 UTC by Iñigo Martínez
Modified: 2017-11-14 00:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Rename build options (2.89 KB, patch)
2017-11-10 16:05 UTC, Iñigo Martínez
none Details | Review
build: Remove default warning level (926 bytes, patch)
2017-11-10 16:06 UTC, Iñigo Martínez
committed Details | Review
build: Migrate to new meson porting guidelines (3.21 KB, patch)
2017-11-13 17:46 UTC, Iñigo Martínez
committed Details | Review

Description Iñigo Martínez 2017-11-10 16:02:43 UTC
There are new meson porting guidelines[0] for naming the options, so option names should be changed. bijiben also uses `1` as the project's default warning level. However, meson already uses this level as the default warning level.

[0] https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting
Comment 1 Iñigo Martínez 2017-11-10 16:05:54 UTC
Created attachment 363356 [details] [review]
build: Rename build options

Following the new meson porting guidelines[0], this patch renames the build options. The list of changes is as follows:

- Remove the `enable` prefix from boolean options.
- The character separator from multi-word options has been changed
  to underscore (`_`).

[0] https://wiki.gnome.org/Initiatives/GnomeGoals/MesonPorting
Comment 2 Iñigo Martínez 2017-11-10 16:06:39 UTC
Created attachment 363357 [details] [review]
build: Remove default warning level

bijiben uses `1` as the project's default warning level. However, meson already uses this level as the default warning level, so it's actually unnecessary.

This patch removes the warning level from project's default options.
Comment 3 Iñigo Martínez 2017-11-13 17:46:35 UTC
Created attachment 363531 [details] [review]
build: Migrate to new meson porting guidelines

This patch also removes the `-Werror` compiler flag, as it is already included in meson's warning levels.
Comment 4 Isaque Galdino 2017-11-14 00:31:41 UTC
Review of attachment 363357 [details] [review]:

Thanks
Comment 5 Isaque Galdino 2017-11-14 00:32:05 UTC
Review of attachment 363531 [details] [review]:

Thanks.