After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790154 - check for rpmatch(3) availability
check for rpmatch(3) availability
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
git master
Other OpenBSD
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-10 08:51 UTC by Antoine Jacoutot
Modified: 2017-11-10 17:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
check for rpmatch(3) availability (1.46 KB, patch)
2017-11-10 08:51 UTC, Antoine Jacoutot 		none Details | Review
don't use rpmatch (862 bytes, patch)
2017-11-10 16:12 UTC, Antoine Jacoutot 		accepted-commit_now Details | Review

Description Antoine Jacoutot 2017-11-10 08:51:25 UTC 
Created attachment 363326 [details] [review]
check for rpmatch(3) availability

Hi.

Some systems (like OpenBSD) do not provide the rpmatch function, so directly fallback to atoi(3) in that case.
May I push this?
Thanks.
Comment 1 Ray Strode [halfline] 2017-11-10 15:22:06 UTC 
if rpmatch isn't available, let's just not use it at all. it's not that great of a function anyway.

I'd really rather avoid an #ifdef for this.
Comment 2 Antoine Jacoutot 2017-11-10 16:12:41 UTC 
Created attachment 363359 [details] [review]
don't use rpmatch

Sure it's even simpler this way :-)
Comment 3 Ray Strode [halfline] 2017-11-10 17:23:55 UTC 
Review of attachment 363359 [details] [review]:

++
Comment 4 Antoine Jacoutot 2017-11-10 17:26:07 UTC 
Thanks, pushed as fa8de58b