After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790121 - Remove a11y-keyboard plugin from g-s-d
Remove a11y-keyboard plugin from g-s-d
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: a11y-keyboard
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Rui Matos
gnome-settings-daemon-maint
Depends on: 788564 792932
Blocks:
 
 
Reported: 2017-11-09 14:54 UTC by Olivier Fourdan
Modified: 2018-01-26 15:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] plugins: Remove a11y-keyboard (40.06 KB, patch)
2017-11-09 14:57 UTC, Olivier Fourdan
none Details | Review
[PATCH v2] plugins: Remove a11y-keyboard (41.52 KB, patch)
2018-01-11 12:44 UTC, Olivier Fourdan
committed Details | Review

Description Olivier Fourdan 2017-11-09 14:54:44 UTC
Description:

Bug 788564 implements the keyboard acccessibility features in mutter/clutter backends, including for X11 AccessX configuration under X11, so once the patches from bug 788564 have landed we can remove that functionality from gnome-settings-daemon.
Comment 1 Olivier Fourdan 2017-11-09 14:57:17 UTC
Created attachment 363293 [details] [review]
[PATCH] plugins: Remove a11y-keyboard

To land after bug 710012 is closed ...
Comment 2 Olivier Fourdan 2017-11-09 14:58:35 UTC
Err. I meant, to land after bug 788564 is closed (sorry wrong copy/paste of the bug #)
Comment 3 Olivier Fourdan 2017-11-16 13:56:45 UTC
Patches from bug 788564 to handle AccessX in clutter/mutter have landed now, we should consider this patch to remove that from g-s-d.
Comment 4 Olivier Fourdan 2018-01-11 08:19:15 UTC
Humble ping, all the bits to handle keyboard accessibility in mutter/gnome-shell have now landed, we need to remove the same from g-s-d
Comment 5 Olivier Fourdan 2018-01-11 12:44:37 UTC
Created attachment 366655 [details] [review]
[PATCH v2] plugins: Remove a11y-keyboard

Remove some more bits from configure.ac (thanks Carlos!) and po/POTFILES.in
Comment 6 Bastien Nocera 2018-01-26 11:03:56 UTC
Review of attachment 366655 [details] [review]:

Looks good, but you'll also need to patch gnome-session's default session so it doesn't try to launch this plugin.
Comment 7 Olivier Fourdan 2018-01-26 11:17:17 UTC
(In reply to Bastien Nocera from comment #6)
> Looks good, but you'll also need to patch gnome-session's default session so
> it doesn't try to launch this plugin.

I don;t understand which default session, isn't gnome-session using “desktop” files nowadays for starting g-s-d plugins?

Removing the plugin along with its  org.gnome.SettingsDaemon.A11yKeyboard.desktop” should prevent gnome-session from starting it.
Comment 8 Bastien Nocera 2018-01-26 11:31:41 UTC
In gnome-session:
$ git grep -i A11yKeyboard
data/gnome.session.desktop.in.in:RequiredComponents=org.gnome.Shell;org.gnome.SettingsDaemon.A11yKeyboard;org.gnome.SettingsDaemon.A11ySettings;org.gnome.SettingsDaemon.Clipboard;org.gnome.SettingsDaemon.Color;org.gnome.SettingsDaemon.Datetime;org.gnome.SettingsDaemon.Housekeeping;org.gnome.SettingsDaemon.Keyboard;org.gnome.SettingsDaemon.MediaKeys;org.gnome.SettingsDaemon.Mouse;org.gnome.SettingsDaemon.Power;org.gnome.SettingsDaemon.PrintNotifications;org.gnome.SettingsDaemon.Rfkill;org.gnome.SettingsDaemon.ScreensaverProxy;org.gnome.SettingsDaemon.Sharing;org.gnome.SettingsDaemon.Smartcard;org.gnome.SettingsDaemon.Sound;org.gnome.SettingsDaemon.Wacom;org.gnome.SettingsDaemon.XSettings;

It's a require component, the session will fail if the .desktop file isn't there.
Comment 9 Olivier Fourdan 2018-01-26 12:58:53 UTC
Ah thanks, I should post the fix for gnome-session first then!
Comment 10 Olivier Fourdan 2018-01-26 15:03:44 UTC
Comment on attachment 366655 [details] [review]
[PATCH v2] plugins: Remove a11y-keyboard

attachment 366655 [details] [review] pushed to git master as commit 9553071d - plugins: Remove a11y-keyboard
Comment 11 Olivier Fourdan 2018-01-26 15:04:00 UTC
Thanks!