GNOME Bugzilla – Bug 790121
Remove a11y-keyboard plugin from g-s-d
Last modified: 2018-01-26 15:04:00 UTC
Description: Bug 788564 implements the keyboard acccessibility features in mutter/clutter backends, including for X11 AccessX configuration under X11, so once the patches from bug 788564 have landed we can remove that functionality from gnome-settings-daemon.
Created attachment 363293 [details] [review] [PATCH] plugins: Remove a11y-keyboard To land after bug 710012 is closed ...
Err. I meant, to land after bug 788564 is closed (sorry wrong copy/paste of the bug #)
Patches from bug 788564 to handle AccessX in clutter/mutter have landed now, we should consider this patch to remove that from g-s-d.
Humble ping, all the bits to handle keyboard accessibility in mutter/gnome-shell have now landed, we need to remove the same from g-s-d
Created attachment 366655 [details] [review] [PATCH v2] plugins: Remove a11y-keyboard Remove some more bits from configure.ac (thanks Carlos!) and po/POTFILES.in
Review of attachment 366655 [details] [review]: Looks good, but you'll also need to patch gnome-session's default session so it doesn't try to launch this plugin.
(In reply to Bastien Nocera from comment #6) > Looks good, but you'll also need to patch gnome-session's default session so > it doesn't try to launch this plugin. I don;t understand which default session, isn't gnome-session using “desktop” files nowadays for starting g-s-d plugins? Removing the plugin along with its org.gnome.SettingsDaemon.A11yKeyboard.desktop” should prevent gnome-session from starting it.
In gnome-session: $ git grep -i A11yKeyboard data/gnome.session.desktop.in.in:RequiredComponents=org.gnome.Shell;org.gnome.SettingsDaemon.A11yKeyboard;org.gnome.SettingsDaemon.A11ySettings;org.gnome.SettingsDaemon.Clipboard;org.gnome.SettingsDaemon.Color;org.gnome.SettingsDaemon.Datetime;org.gnome.SettingsDaemon.Housekeeping;org.gnome.SettingsDaemon.Keyboard;org.gnome.SettingsDaemon.MediaKeys;org.gnome.SettingsDaemon.Mouse;org.gnome.SettingsDaemon.Power;org.gnome.SettingsDaemon.PrintNotifications;org.gnome.SettingsDaemon.Rfkill;org.gnome.SettingsDaemon.ScreensaverProxy;org.gnome.SettingsDaemon.Sharing;org.gnome.SettingsDaemon.Smartcard;org.gnome.SettingsDaemon.Sound;org.gnome.SettingsDaemon.Wacom;org.gnome.SettingsDaemon.XSettings; It's a require component, the session will fail if the .desktop file isn't there.
Ah thanks, I should post the fix for gnome-session first then!
Comment on attachment 366655 [details] [review] [PATCH v2] plugins: Remove a11y-keyboard attachment 366655 [details] [review] pushed to git master as commit 9553071d - plugins: Remove a11y-keyboard
Thanks!