After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790101 - tries to autocomplete "else"
tries to autocomplete "else"
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-09 00:20 UTC by Shawn Landden
Modified: 2017-11-09 01:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ctags: try to avoid activating various keywords (4.20 KB, patch)
2017-11-09 01:17 UTC, Christian Hergert
committed Details | Review

Description Shawn Landden 2017-11-09 00:20:39 UTC
I'm getting ctags trying to complete "else" into "EILSEQ". Ctags needs to know about reserved words, or somthing else.
Comment 1 Christian Hergert 2017-11-09 01:17:52 UTC
Created attachment 363270 [details] [review]
ctags: try to avoid activating various keywords

We don't have a really great way to deal with this using the
completion system provided by GtkSourceView (as there is not a
way to get the activation key to perform the desired indent or
space). But we can at least avoid activating the item and leave
the insertion cursor where it was.

To do this better, we need to build a new completion engine for
Builder/GSV that does things a bit differently.

Either way, this avoids some common keywords. If you're trying
to get a newline afterwards, you'll have to hit enter a second
time (as this will just dismiss the completion window).
Comment 2 Christian Hergert 2017-11-09 01:19:29 UTC
Thanks for reporting!

Longer term, we'll need to build a new completion engine to handle corner
cases like this more effectively. This patch will stop the completion request
leaving the insertion cursor at the same location. So hitting enter a second
time will be needed if you want a newline.

We can't automatically insert the newline/indent from the completion provider
because it doesn't know about those settings, nor does it know what key was
pressed to activate the completion item.

Attachment 363270 [details] pushed as cc287c2 - ctags: try to avoid activating various keywords