After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790097 - GNOME 3.26 mozjs crashes on ARM
GNOME 3.26 mozjs crashes on ARM
Status: RESOLVED FIXED
Product: Release Engineering
Classification: Infrastructure
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Release Engineering People
Release Engineering People
Depends on:
Blocks:
 
 
Reported: 2017-11-08 22:31 UTC by Philip Chimento
Modified: 2017-11-09 02:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mozjs52: Adjust build flags on ARM (976 bytes, patch)
2017-11-08 22:31 UTC, Philip Chimento 		accepted-commit_now Details | Review

Description Philip Chimento 2017-11-08 22:31:37 UTC 
On armhf, the `js52` and `gjs` interpreters both crash immediately upon startup. This can be prevented with a compiler flag, but it's not clear whether this is a mozjs bug or a compiler bug.
Comment 1 Philip Chimento 2017-11-08 22:31:54 UTC 
Created attachment 363263 [details] [review]
mozjs52: Adjust build flags on ARM

Without this, js52 and gjs crash immediately upon startup on ARM. The fix
is suggested by https://bugzilla.mozilla.org/show_bug.cgi?id=1337263
Comment 2 Philip Chimento 2017-11-08 22:32:15 UTC 
(This patch is for gnome-sdk-images. I'm not sure where else to file it.)
Comment 3 Michael Catanzaro 2017-11-09 00:09:07 UTC 
Review of attachment 363263 [details] [review]:

OK if you add a comment with a link to this issue, otherwise nobody's going to know why it's there.
Comment 4 Philip Chimento 2017-11-09 00:16:20 UTC 
Comments aren't valid JSON, although I guess there are already other comments in that file...
Comment 5 Michael Catanzaro 2017-11-09 00:56:38 UTC 
I think all the software that processes these files understands comments.
Comment 6 Philip Chimento 2017-11-09 02:14:24 UTC 
Python's json module doesn't (https://github.com/endlessm/flapjack/blob/e19c1be38ff4715a7f45834bb279cc65bee74a38/flapjack/util.py#L14), but I added a comment and pushed to master and gnome-3-26.
Comment 7 Michael Catanzaro 2017-11-09 02:49:47 UTC 
Most json parsers don't... I think json-glib is unusual in allowing comments.

Personally, I'm starting to think using json was a mistake, for this reason alone.