After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790073 - matroskademux: remove dead code dealing with segment->position
matroskademux: remove dead code dealing with segment->position
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-08 17:30 UTC by Alicia Boya García
Modified: 2017-11-08 17:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.35 KB, patch)
2017-11-08 17:32 UTC, Alicia Boya García 		none Details | Review

Description Alicia Boya García 2017-11-08 17:30:52 UTC 
matroskademux does not really use `GstSegment.position`. There is currently code that writes some values to it, but no code that reads them.
Comment 1 Alicia Boya García 2017-11-08 17:32:58 UTC 
Created attachment 363237 [details] [review]
Patch
Comment 2 Alicia Boya García 2017-11-08 17:50:04 UTC 
On closer inspection I've noticed there are many instances of `segment.position` that I was not catching due to searching for `segment->position`. Closing this...