After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790054 - california doesn't build with libical-3.0.0
california doesn't build with libical-3.0.0
Status: RESOLVED WONTFIX
Product: california
Classification: Other
Component: general
master
Other Linux
: Normal normal
: ---
Assigned To: California Maintainers
California Maintainers
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2017-11-08 11:54 UTC by Matthias Klose
Modified: 2019-10-10 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Matthias Klose 2017-11-08 11:54:35 UTC
libical-3.0.0 comes with API changes, first error:

pd_DocumentRDF.cpp: In member function ‘virtual void PD_RDFEvent::exportToFile(const string&) const’:
pd_DocumentRDF.cpp:2272:43: error: ‘icaltime_from_timet’ was not declared in this scope
         icalcomponent_set_dtstart( c,     icaltime_from_timet( m_dtstart, 0 ) );
                                           ^~~~~~~~~~~~~~~~~~~
pd_DocumentRDF.cpp:2272:43: note: suggested alternative: ‘icaltime_as_timet’
         icalcomponent_set_dtstart( c,     icaltime_from_timet( m_dtstart, 0 ) );
                                           ^~~~~~~~~~~~~~~~~~~
                                           icaltime_as_timet
Comment 1 Jan Tojnar 2018-06-29 10:57:54 UTC
There is a patch downstream in Fedora, not sure why it was not sent upstream https://src.fedoraproject.org/rpms/california/blob/2af9a6a1b67b53f3fca1472c5350dc11a1acf28f/f/california-0.4.0-libical-3.0.patch

NEEDINFO the patch author Milan Crha
Comment 2 Milan Crha 2018-06-29 11:43:01 UTC
No idea, it's a long time ago. It can be I missed to propose the change upstream due to more projects being affected and I simply overlooked this one. In any case, it's my fault I didn't propose it here earlier. I'm sorry.
Comment 3 Milan Crha 2018-06-29 12:13:57 UTC
I'm been about to commit the change when I realized the Fedora patch is not good, because it expects the libical 3.0.0+. Using version before that can lead to side effects, which is not what you want. Feel free to extend the patch to have conditional compile for older libical (and older vala, if those other changes are about it and can work only with newer vala).
Comment 4 Jan Tojnar 2018-06-30 04:40:26 UTC
Hmm, the app uses custom VAPI bindings for libical, I am also not sure how to make that conditional, other than generating another VAPI for libical 3 and switching based on libical version. The app should probably switch to libical-glib which offers VALA bindings.
Comment 5 André Klapper 2019-10-10 14:03:07 UTC
California is not under active development anymore and saw its last non-cosmetic code changes in March 2016: https://gitlab.gnome.org/Archive/california/commits/master

Its codebase has been archived in https://gitlab.gnome.org/Archive/california/issues/1

Closing this report as WONTFIX as part of GNOME Housekeeping to reflect reality. Please feel free to reopen this ticket if anyone takes the responsibility for active development again.

You may want to use `gnome-calendar`.