After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 790017 - middle click the Back button
middle click the Back button
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Controls
3.26.x
Other Linux
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-07 14:35 UTC by Dan Jacobson
Modified: 2017-11-12 00:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
header-bar: Fix middle click action for forward/back buttons (1.20 KB, patch)
2017-11-11 03:25 UTC, Mal 		none Details | Review
header-bar: Fix middle click action for forward/back buttons (1.25 KB, patch)
2017-11-11 19:28 UTC, Mal 		committed Details | Review

Description Dan Jacobson 2017-11-07 14:35:33 UTC 
User middle clicks the Back button.

One would expect he would get a new tab, containing the previous page.

Instead he just gets an empty tab.

Not sure if related to Bug 611400.

Pretty sure not a Webkit bug as their minibrowser only has rudimentary tab support.
Comment 1 Michael Catanzaro 2017-11-07 14:55:00 UTC 
(In reply to Dan Jacobson from comment #0)
> Pretty sure not a Webkit bug as their minibrowser only has rudimentary tab
> support.

Yeah, this is (almost surely) an Epiphany bug.
Comment 2 Mal 2017-11-11 03:25:10 UTC 
Created attachment 363381 [details] [review]
header-bar: Fix middle click action for forward/back  buttons
Comment 3 Michael Catanzaro 2017-11-11 15:38:17 UTC 
Review of attachment 363381 [details] [review]:

::: src/ephy-header-bar.c
@@ +503,3 @@
   action_group = gtk_widget_get_action_group (GTK_WIDGET (header_bar->window), "toolbar");
 
+  direction = strstr (action_name, "back") ? EPHY_NAVIGATION_HISTORY_DIRECTION_BACK

Oh wow.

I would tighten this up a bit more, since there's only two possible action names here:

strcmp (action_name, "navigation-back") == 0 ?
Comment 4 Mal 2017-11-11 19:28:59 UTC 
Created attachment 363405 [details] [review]
header-bar: Fix middle click action for forward/back  buttons

Thanks for the feedback.