GNOME Bugzilla – Bug 789925
Maps is not listed in the Open With menu for KML files
Last modified: 2017-11-08 21:30:44 UTC
When I try to open a KML file, Maps is not listed as an option for this file type. It looks like this happens because there is no file field for the Exec property in org.gnome.Maps.desktop.
Created attachment 363003 [details] [review] Patch that adds "%U" to Exec Here is a simple patch that resolves this.
Review of attachment 363003 [details] [review]: LGTM
Thanks for the patch!
Interestingly enough, double-clicking on supported files worked, but Maps didn't appear in the "Open with other" dialog. It looks like other apps does have the %U, so it seems to be fit.
Glad that solves it! Thanks for the excellent app :) Yeah, I was remembering it seemed to work sometimes as well, but couldn't quite put my finger on it. Maybe an issue with Nautilus or GAppInfo…?
Created attachment 363257 [details] [review] socialPlaceMarker: Compensate for JS string indecies starting at 0 The pseudo code for the iterative Levenstein implementation on Wikipedia assumes 1-indexed input strings. To minimize the impact just offset the indecies in the comparison statement using values from the strings.
Created attachment 363258 [details] [review] socialPlaceMatcher: Compensate for JS string indecies starting at 0 The pseudo code for the iterative Levenstein implementation on Wikipedia assumes 1-indexed input strings. To minimize the impact just offset the indecies in the comparison statement using values from the strings.