After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789921 - Removed border around contact images
Removed border around contact images
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.26
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-11-04 23:28 UTC by Günther Wutz
Modified: 2017-11-09 07:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
stylesheet change to remove border around contact images (888 bytes, patch)
2017-11-04 23:28 UTC, Günther Wutz
none Details | Review
remove inner shadow to get flat styling (1.69 KB, patch)
2017-11-05 10:18 UTC, Günther Wutz
none Details | Review
make border round (740 bytes, patch)
2017-11-05 15:19 UTC, Günther Wutz
none Details | Review

Description Günther Wutz 2017-11-04 23:28:14 UTC
Created attachment 363000 [details] [review]
stylesheet change to remove border around contact images

this patch removes the borders around contact images. This matches the design of that application.
Comment 1 Niels De Graef 2017-11-05 10:04:37 UTC
Hi Günther!

First of all, thanks for the patch. I'v always found that border annoying but hadn't gotten to doing anything about it yet. Anyway, although this patch technically works, your commit message sparked my interest: could you try avoiding the extra CSS by just removing the shadow-type: in from the list entries' avatars and see if that works too?
Comment 2 Günther Wutz 2017-11-05 10:18:49 UTC
Created attachment 363006 [details] [review]
remove inner shadow to get flat styling

Hi Niels!

Removed the inner shadow and works now like expected. I was just not sure if a theme author should be able to show borders.
Comment 3 Niels De Graef 2017-11-05 15:00:09 UTC
Okay, I looked into why we had the borders in the first place, and there does seem to be a valid reason on why they should be there: see bug 699462.

So, the best of both worlds would be to keep the border but make its corners rounded as well. Don't worry about the difference with the mockup designs for Contacts, those are *very* old.
Comment 4 Günther Wutz 2017-11-05 15:08:21 UTC
So the solution would be a css style change right?

.main-avatar-frame border {
  border-radius: 5px;
}
Comment 5 Niels De Graef 2017-11-05 15:13:37 UTC
Yes, adding that to the CSS is indeed the best choice :-)

Would you mind attaching a patch? Then I'll get it committed.
Comment 6 Günther Wutz 2017-11-05 15:19:37 UTC
Created attachment 363017 [details] [review]
make border round

as discussed
Comment 7 Niels De Graef 2017-11-09 07:04:02 UTC
Look great! Thanks Günther :-)


Landed on master as commit bf45434fe0b1b62b7869b59381b23d486220ae85.