GNOME Bugzilla – Bug 789921
Removed border around contact images
Last modified: 2017-11-09 07:04:02 UTC
Created attachment 363000 [details] [review] stylesheet change to remove border around contact images this patch removes the borders around contact images. This matches the design of that application.
Hi Günther! First of all, thanks for the patch. I'v always found that border annoying but hadn't gotten to doing anything about it yet. Anyway, although this patch technically works, your commit message sparked my interest: could you try avoiding the extra CSS by just removing the shadow-type: in from the list entries' avatars and see if that works too?
Created attachment 363006 [details] [review] remove inner shadow to get flat styling Hi Niels! Removed the inner shadow and works now like expected. I was just not sure if a theme author should be able to show borders.
Okay, I looked into why we had the borders in the first place, and there does seem to be a valid reason on why they should be there: see bug 699462. So, the best of both worlds would be to keep the border but make its corners rounded as well. Don't worry about the difference with the mockup designs for Contacts, those are *very* old.
So the solution would be a css style change right? .main-avatar-frame border { border-radius: 5px; }
Yes, adding that to the CSS is indeed the best choice :-) Would you mind attaching a patch? Then I'll get it committed.
Created attachment 363017 [details] [review] make border round as discussed
Look great! Thanks Günther :-) Landed on master as commit bf45434fe0b1b62b7869b59381b23d486220ae85.