After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789919 - rst.lang: Words with underscores are matched as links
rst.lang: Words with underscores are matched as links
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
git master
Other Linux
: Normal minor
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-04 21:43 UTC by Tobias Schönberg
Modified: 2017-11-05 11:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rst.lang: Don't match words with underscores as links (959 bytes, patch)
2017-11-04 22:00 UTC, Tobias Schönberg 		accepted-commit_now Details | Review

Description Tobias Schönberg 2017-11-04 21:43:40 UTC 
Currently words with underscores (e.g. "$module_name.plugin") are wrongly highlighted as links. Sending a patch.
Comment 1 Tobias Schönberg 2017-11-04 22:00:00 UTC 
Created attachment 362997 [details] [review]
rst.lang: Don't match words with underscores as links

Currently words with underscores are matched as links. This commit
adds a condition to the regex that a word boundary has to follow
the underscore.
Comment 2 Sébastien Wilmet 2017-11-05 10:07:13 UTC 
Review of attachment 362997 [details] [review]:

Looks good, thanks.
Comment 3 Tobias Schönberg 2017-11-05 11:50:07 UTC 
Commit:

https://git.gnome.org/browse/gtksourceview/commit/?id=c25d8e6