After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789869 - [PATCH] wifi: add a refresh button
[PATCH] wifi: add a refresh button
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-03 15:12 UTC by Xiang Fan
Modified: 2018-01-21 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-wifi-add-a-refresh-button.patch (6.36 KB, patch)
2017-11-03 15:12 UTC, Xiang Fan 		none Details | Review
wifi: Add a refresh button (6.29 KB, patch)
2018-01-21 15:13 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Xiang Fan 2017-11-03 15:12:25 UTC 
Created attachment 362906 [details] [review]
0001-wifi-add-a-refresh-button.patch

This way, user can scan anytime without having to wait.

======
I separated this patch from #786736 because they're not really dependent on each other. A new button design is also included.
Comment 1 Georges Basile Stavracas Neto 2018-01-21 15:07:43 UTC 
Review of attachment 362906 [details] [review]:

Some comments

::: panels/network/cc-wifi-panel.c
@@ +453,3 @@
 
+static void
+button_refresh_clicked_cb (GtkButton *button, CcWifiPanel *self)

Style issue.

::: panels/network/net-device-wifi.c
@@ +101,3 @@
+        nm_device = net_device_get_nm_device (NET_DEVICE (device_wifi));
+        g_return_if_fail (nm_device_get_device_type (nm_device)
+                          == NM_DEVICE_TYPE_WIFI);

Nitpick: Should be only one line

::: panels/network/wifi.ui
@@ +216,3 @@
+                            <property name="margin_bottom">6</property>
+                            <property name="use_underline">True</property>
+                            <signal name="clicked" handler="button_refresh_clicked_cb" object="CcWifiPanel" swapped="no"/>

The button should have no relief. It would look much less intrusive.
Comment 2 Georges Basile Stavracas Neto 2018-01-21 15:13:00 UTC 
Created attachment 367176 [details] [review]
wifi: Add a refresh button

Improvements over the first patch.
Comment 3 Georges Basile Stavracas Neto 2018-01-21 15:13:29 UTC 
Thanks for the patch!

Attachment 367176 [details] pushed as 5ad72b6 - wifi: Add a refresh button