After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789844 - adaptivedemux: deadlock on task stop
adaptivedemux: deadlock on task stop
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.12.0
Other Linux
: Normal major
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-03 07:18 UTC by Ravi
Modified: 2018-11-03 14:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
if the streams are not cancelled during task stop and we are in prerolling then unblock the data push thread. (1.21 KB, patch)
2017-11-03 07:18 UTC, Ravi 		none Details | Review

Description Ravi 2017-11-03 07:18:27 UTC 
Created attachment 362871 [details] [review]
if the streams are not cancelled during task stop and we are in prerolling then unblock the data push thread.

The deadlock is observed when we quickly do start-stop pipeline.

The other use case if you push new mpd buffer to adaptivedemux and then shutdown the pipeline.
Comment 1 Tim-Philipp Müller 2017-11-03 08:25:10 UTC 
Thanks for the patch, but could you please provide a git format-patch formatted patch with author info and commit message?
Comment 2 Tim-Philipp Müller 2018-01-18 22:18:26 UTC 
Ravi: ping?

Also: the preroll_cond is g_cond_broadcast() right after this for loop inside of which you add the additional g_cond_broadcast, and there is nothing inside the loop that should block/hang as far as I can tell, other than the lock (but your addition is inside the lock taken, so that can't be a problem).

Are both really needed? What is the stack trace when it hangs?
Comment 3 GStreamer system administrator 2018-11-03 14:14:59 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/627.