After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789841 - sdpmessage: allow setting NULL to _add_attribute
sdpmessage: allow setting NULL to _add_attribute
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-11-03 02:53 UTC by Justin Kim
Modified: 2017-11-03 06:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sdpmessage: add_attribute accepts NULL value (2.79 KB, patch)
2017-11-03 02:53 UTC, Justin Kim 		none Details | Review
sdpmessage: add_attribute accepts NULL value (3.67 KB, patch)
2017-11-03 03:12 UTC, Justin Kim 		committed Details | Review

Description Justin Kim 2017-11-03 02:53:09 UTC 
Created attachment 362864 [details] [review]
sdpmessage: add_attribute accepts NULL value

The attribute can be defined without value regardless session-level
or media-level.
Although `gst_sdp_message_insert_attribute` can be used to set NULL,
it would be easier if `gst_sdp_message_add_attribute` accepts NULL.
Comment 1 Justin Kim 2017-11-03 03:12:54 UTC 
Created attachment 362866 [details] [review]
sdpmessage: add_attribute accepts NULL value
Comment 2 Matthew Waters (ystreet00) 2017-11-03 06:58:19 UTC 
commit 91179622eb3b4b51785b4f19dc8a033fbeeda492
Author: Justin Kim <justin.kim@collabora.com>
Date:   Wed Nov 1 11:23:17 2017 +0900

    sdpmessage: add_attribute accepts NULL value
    
    The attribute can be defined without value regardless session-level
    or media-level.
    Although `gst_sdp_message_insert_attribute` can be used to set NULL,
    it would be easier if `gst_sdp_message_add_attribute` accepts NULL.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=789841