After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789799 - Missing return in no-void function
Missing return in no-void function
Status: RESOLVED FIXED
Product: gmime
Classification: Other
Component: general
3.0.x
Other All
: Normal normal
: ---
Assigned To: Jeffrey Stedfast
Jeffrey Stedfast
Depends on:
Blocks:
 
 
Reported: 2017-11-02 04:03 UTC by Felix Zhang
Modified: 2017-11-02 19:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A minor fix. (726 bytes, patch)
2017-11-02 04:23 UTC, Felix Zhang 		none Details | Review
A minor fix. (723 bytes, patch)
2017-11-02 04:31 UTC, Felix Zhang 		none Details | Review

Description Felix Zhang 2017-11-02 04:03:34 UTC 
In the file gmime/gmime-autocrypt.c, the function:
GMimeAutocryptHeader *g_mime_autocrypt_header_list_get_header_at()
has a missing return in case the if condition is not met. This causes build failures on the openSUSE open build service.
Comment 1 Felix Zhang 2017-11-02 04:23:21 UTC 
Created attachment 362790 [details] [review]
A minor fix.
Comment 2 Felix Zhang 2017-11-02 04:31:17 UTC 
Created attachment 362791 [details] [review]
A minor fix.

Fixed the indentation.
Comment 3 Jeffrey Stedfast 2017-11-02 19:10:52 UTC 
You should be using the GitHub version of gmime instead of git.gnome.org sources.

This was fixed a few days ago: https://github.com/jstedfast/gmime/commit/3ebcdd9289889a961e08a61db4dd6343ed9b660b