After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789796 - "jhbuild build" command fails because of libosinfo autogenargs
"jhbuild build" command fails because of libosinfo autogenargs
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2017-11-02 02:07 UTC by ryu.insang
Modified: 2017-11-02 03:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
core-deps-3.28: Enable build of libosinfo tests (1.04 KB, patch)
2017-11-02 03:38 UTC, Michael Catanzaro
committed Details | Review

Description ryu.insang 2017-11-02 02:07:01 UTC
modulesets/gnome-suites-core-deps-3.28.modules:

   <autotools id="libosinfo"
             autogenargs="--enable-tests=no --enable-werror=no">
     <branch repo="gitlab.com" module="libosinfo/libosinfo.git"/>



libosinfo/configure.ac:

if test "x$enable_tests" != "xno" ; then
  have_curl=no
  PKG_CHECK_MODULES([CURL], [libcurl], [have_curl=yes], [:])
  AC_SUBST(CURL_CFLAGS)
  AC_SUBST(CURL_LIBS)
  AM_CONDITIONAL([HAVE_CURL],[test "x$have_curl" = "xyes"])
fi



These two settings collides. HAVE_CURL variable can be set only if "enable_tests" has not "no" value but build system pass "--enable-tests=no". This makes error because HAVE_CURL is not set. This is the error message.


"""
configure: error: conditional "HAVE_CURL" was never defined.
Usually this means the macro was only invoked conditionally.
"""
Comment 1 Michael Catanzaro 2017-11-02 03:38:43 UTC
Thanks for reporting

The following fix has been pushed:
0e04fce core-deps-3.28: Enable build of libosinfo tests
Comment 2 Michael Catanzaro 2017-11-02 03:38:46 UTC
Created attachment 362789 [details] [review]
core-deps-3.28: Enable build of libosinfo tests

The configure script is broken, and this works around the issue.