GNOME Bugzilla – Bug 789786
Fix object path for sync settings and write a migrator
Last modified: 2017-11-01 19:44:02 UTC
Sync settings are stored in dconf under the object path /org/gnome/Epiphany, but all our other settings are under /org/gnome/epiphany. Let's write a migrator....
This isn't quite right... we're using /Epiphany for all relocatable schemas. That's not what's specified in the gschema.xml, but I suppose the paths there are probably ignored, because it's relocatable, after all.
(In reply to Michael Catanzaro from comment #1) > This isn't quite right... we're using /Epiphany for all relocatable schemas. > That's not what's specified in the gschema.xml, but I suppose the paths > there are probably ignored, because it's relocatable, after all. But in ephy-settings.c, ephy_settings_init(), I see /org/gnome/epiphany used for the path. Hmm, I'm thoroughly confused now.
Ah, I'm dumb. It's only a problem for sync settings, which are not relocatable. I had accidentally set an /org/gnome/Epiphany/web setting in the past, which did nothing because it should have been /org/gnome/epiphany/web. That's why I was confused.
Created attachment 362776 [details] [review] Fix location of sync settings and add a migrator Unfortunately we have to keep the old schema around indefinitely, to not break migrations.
Review of attachment 362776 [details] [review]: LGTM! Thanks for fixing this!
Attachment 362776 [details] pushed as c9860e4 - Fix location of sync settings and add a migrator