After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789767 - two libmount patches
two libmount patches
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-11-01 14:23 UTC by Colin Walters
Modified: 2017-11-02 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
automake (953 bytes, patch)
2017-11-01 14:23 UTC, Colin Walters 		none Details | Review
work with old libmount (1.67 KB, patch)
2017-11-01 14:24 UTC, Colin Walters 		committed Details | Review
updated to use 1.13.3 (955 bytes, patch)
2017-11-01 18:40 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2017-11-01 14:23:42 UTC 
Created attachment 362748 [details] [review]
automake

For https://bugzilla.redhat.com/show_bug.cgi?id=1508056
Comment 1 Colin Walters 2017-11-01 14:24:01 UTC 
Created attachment 362749 [details] [review]
work with old libmount
Comment 2 Philip Withnall 2017-11-01 15:40:29 UTC 
Review of attachment 362749 [details] [review]:

++
Comment 3 Philip Withnall 2017-11-01 15:44:25 UTC 
Review of attachment 362748 [details] [review]:

> In 5faaaac92c we jumped all the way from `1.11` to `1.14`

I think you mean commit 5c13bf9bcf0, right?

Emmanuele, what was the thinking there? Is 1.13 OK? The first version of automake I can find which references subdir-objects is 1.9.
Comment 4 Emmanuele Bassi (:ebassi) 2017-11-01 15:52:27 UTC 
1.14 was the oldest version I had access to, and it's the first version of Automake that complains loudly about subdir-objects.

Automake 1.14 was released in 2013. I don't see any special reason why we should settle on 1.13 just because RHEL is terrible at shipping build dependencies for modern software.

At least make that 1.13.4, which was released alongside 1.14.
Comment 5 Colin Walters 2017-11-01 18:40:07 UTC 
Does it matter much though if we can point people who have newer stacks at meson?

Anyways, like a lot of software changes, it's definitely easy to write the patch to downgrade the version - the hard pard is maintaining it over time.  But that's what I'm signing up to do here; maintaining glib2 in RHEL is part of my job.
Comment 6 Colin Walters 2017-11-01 18:40:27 UTC 
Created attachment 362773 [details] [review]
updated to use 1.13.3
Comment 7 Emmanuele Bassi (:ebassi) 2017-11-01 22:45:41 UTC 
Review of attachment 362773 [details] [review]:

Okay