After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789762 - Support <launchable type="url"> for specifying the location of web apps
Support <launchable type="url"> for specifying the location of web apps
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
git master
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-11-01 12:24 UTC by Peter Oliver
Modified: 2017-12-05 11:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Prefer the launchable tag for the URL of web apps (7.12 KB, patch)
2017-11-10 19:14 UTC, Dimitrios Christidis 		none Details | Review
Prefer the launchable tag for the URL of web apps (7.77 KB, patch)
2017-11-14 21:17 UTC, Dimitrios Christidis 		committed Details | Review

Description Peter Oliver 2017-11-01 12:24:51 UTC 
Gnome Software uses the <url type="homepage"> tag to construct a desktop file to launch web applications with Epiphany.  However, the AppData spec defines a <launchable type="url"> tag for specifying the location of web apps.  If present, this should be used in preference to the homepage URL.

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable
Comment 1 Dimitrios Christidis 2017-11-10 19:14:14 UTC 
Created attachment 363371 [details] [review]
Prefer the launchable tag for the URL of web apps

I have created a patch that addresses this bug for which I would love some feedback. There are two specific points where I’m quite unsure if I approached them correctly.

 1. Is it acceptable that the launchables are stored in a GHashTable instead of a GPtrArray?
 2. Should anything be done in gs_app_to_string_append()?
Comment 2 Richard Hughes 2017-11-14 19:30:22 UTC 
>  1. Is it acceptable that the launchables are stored in a GHashTable

I think it's fine.

> Should anything be done in gs_app_to_string_append

I think that would help debugging; so yes please.
Comment 3 Dimitrios Christidis 2017-11-14 21:17:55 UTC 
Created attachment 363641 [details] [review]
Prefer the launchable tag for the URL of web apps
Comment 4 Richard Hughes 2017-12-05 11:24:00 UTC 
Comment on attachment 363641 [details] [review]
Prefer the launchable tag for the URL of web apps

Looks great, thanks.