GNOME Bugzilla – Bug 789733
Adwaita/HC: Fix entry.flat not being flat
Last modified: 2017-11-01 20:26:46 UTC
The other selectors on :backdrop were overriding that on .flat and leading to the border reappearing and whatnot. Fix that by explicitly applying the .flat style to entry:backdrop also, as we already do for :focus.
Created attachment 362691 [details] [review] Adwaita: Fix :backdropped entry becoming non-.flat by explicitly including &:backdrop in the selector removing the border.
It also seems that in HC, .flat entries are simply never flat, even if not backdropped.
(In reply to Daniel Boles from comment #2) > It also seems that in HC, .flat entries are simply never flat, even if not > backdropped. *removes focus from entry before testing* It's not quite so bad: backdrop ones are OK, but foreground ones need the internal shadow removed.
I see why I originally thought .flat never worked in HC: it doesn't on entry:disabled. That'll need a precedence bump too. I'd better check other pseudoclasses while I'm at it.
Created attachment 362692 [details] [review] HighContrast: Fix .flat entry not being flat • Remove the box-shadow at the top when the entry is in the foreground • Bump precedence so that :disabled entries do not have .flat overridden
Review of attachment 362691 [details] [review]: This also needs to cover :disabled and :backdrop:disabled. At this point I begin to wonder whether there's a better solution than just throwing extra selectors at it. Any thoughts, Lapo/Jakub?
Review of attachment 362692 [details] [review]: And so it continues. HighContrastInverse still shades the background lighter on entry.flat:backdrop
Created attachment 362702 [details] [review] HighContrast: Fix GtkEntry:has-frame not working • Remove the box-shadow at the top when the entry is in the foreground • Bump precedence so that :disabled entries do not have .flat overridden • Also add :backdrop to stop HCInverse getting a lighter BG in :backdrop
Created attachment 362703 [details] [review] Adwaita: Fix Entry:has-frame if backdrop/disabled by explicitly including these in the selector removing the border, to avoid other rules on these pseudoclasses overriding the .flat class.
Attachment 362702 [details] pushed as a03a3c3 - HighContrast: Fix GtkEntry:has-frame not working Attachment 362703 [details] pushed as 40302a5 - Adwaita: Fix Entry:has-frame if backdrop/disabled Let's just get this fixed, for now, but please do push a preferred way to do it, if one exists.