After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789726 - android: -fuse-ld should be in LDFLAGS
android: -fuse-ld should be in LDFLAGS
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
1.12.x
Other Linux
: Normal normal
: 1.12.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 789316
 
 
Reported: 2017-10-31 17:38 UTC by Xavier Claessens
Modified: 2017-11-21 16:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
android: move -fuse-ld to LDFLAGS where it belongs (1.20 KB, patch)
2017-10-31 17:39 UTC, Xavier Claessens
committed Details | Review

Description Xavier Claessens 2017-10-31 17:38:37 UTC
meson doesn't like to have arguments in the CC env variable.
Comment 1 Xavier Claessens 2017-10-31 17:39:22 UTC
Created attachment 362674 [details] [review]
android: move -fuse-ld to LDFLAGS where it belongs
Comment 2 Xavier Claessens 2017-10-31 17:40:20 UTC
tested compiling gstreamer core with that change, so I guess it should be fine.
Comment 3 Tim-Philipp Müller 2017-10-31 17:54:10 UTC
I suspect this will need more changes for Meson anyway, because CC is supposed to be the native compiler there, no?
Comment 4 Xavier Claessens 2017-10-31 18:03:35 UTC
Yes, that's just one step.
Comment 5 Xavier Claessens 2017-10-31 18:05:46 UTC
But this change should be the right thing to do even when not using meson. I have a full build with "chmod -x" on all linkers but gold currently running. Will see if all goes well.
Comment 6 Xavier Claessens 2017-10-31 18:50:39 UTC
The full build went fine, with that command:
"./cerbero-uninstalled -c config/cross-android-arm64.cbc package gstreamer-1.0"
Comment 7 Sebastian Dröge (slomo) 2017-11-09 09:06:18 UTC
Attachment 362674 [details] pushed as c34f983 - android: move -fuse-ld to LDFLAGS where it belongs