After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789723 - [PATCH] gdbus-codegen: Call abspath() earlier
[PATCH] gdbus-codegen: Call abspath() earlier
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gdbus
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-10-31 16:54 UTC by Colin Walters
Modified: 2017-11-06 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] gdbus-codegen: Call abspath() earlier (1.61 KB, patch)
2017-10-31 16:54 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2017-10-31 16:54:09 UTC
Created attachment 362651 [details] [review]
[PATCH] gdbus-codegen: Call abspath() earlier

The previous change from https://bugzilla.gnome.org/show_bug.cgi?id=786785
didn't actually work (for me at least) in the `/bin/gdbus-codegen` case
as the relative `/bin/../share` path works, but then `os.path.abspath()`
breaks it (as it's not doing `realpath()`, and let's not go there).

Fix this by doing the `abspath` first.

Downstream: https://bugzilla.redhat.com/show_bug.cgi?id=1507661
Comment 1 Philip Withnall 2017-10-31 22:05:40 UTC
Review of attachment 362651 [details] [review]:

Sure.
Comment 2 Philip Withnall 2017-11-06 11:58:54 UTC
Comment on attachment 362651 [details] [review]
[PATCH] gdbus-codegen: Call abspath() earlier

Pushed to master as:

commit cb8bfa758fd14794ffeb9cf62fe2a51886b5a6ac (HEAD -> master, origin/master, origin/HEAD)
Author: Colin Walters <walters@verbum.org>
Date:   Tue Oct 31 12:51:09 2017 -0400

    gdbus-codegen: Call abspath() earlier
    
    The previous change from https://bugzilla.gnome.org/show_bug.cgi?id=786785
    didn't actually work (for me at least) in the `/bin/gdbus-codegen` case
    as the relative `/bin/../share` path works, but then `os.path.abspath()`
    breaks it (as it's not doing `realpath()`, and let's not go there).
    
    Fix this by doing the `abspath` first.
    
    Downstream: https://bugzilla.redhat.com/show_bug.cgi?id=1507661
    
    https://bugzilla.gnome.org/show_bug.cgi?id=789723

 gio/gdbus-2.0/codegen/gdbus-codegen.in | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)