After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789722 - GDM isn't starting for some users
GDM isn't starting for some users
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
: 789720 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-10-31 16:51 UTC by Ray Strode [halfline]
Modified: 2017-11-01 20:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
session-worker: Adjust Initialize to behave more like SetupFor* (7.54 KB, patch)
2017-10-31 16:51 UTC, Ray Strode [halfline] 		committed Details | Review
session: don't call gdm_session_defaults_changed from setup (3.37 KB, patch)
2017-10-31 16:51 UTC, Ray Strode [halfline] 		committed Details | Review
[PATCH] session-worker: Use g_variant_dup_string where possible (3.44 KB, patch)
2017-10-31 16:53 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review
Log excerpt: Failed gnome-xorg session (21.35 KB, text/plain)
2017-10-31 17:23 UTC, Jan Alexander Steffens (heftig) 		  Details
Log excerpt: Successful gnome-xorg session with the Initialize patch (20.83 KB, text/plain)
2017-10-31 17:24 UTC, Jan Alexander Steffens (heftig) 		  Details

Description Ray Strode [halfline] 2017-10-31 16:51:03 UTC 
There's a race condition preventing gdm 3.26.2 from starting for some users.

See

https://bugs.archlinux.org/task/56172

heftig has tracked down the problem to an incomplete implementation of the
new initialize method, leading to GDM changing state before the user is
fully loaded.

There's also some spurious calls to gdm_session_defaults_changed() that I
inadvertently added when forward porting the initial patch from an older gdm
release shipped in RHEL.
Comment 1 Ray Strode [halfline] 2017-10-31 16:51:13 UTC 
Created attachment 362648 [details] [review]
session-worker: Adjust Initialize to behave more like SetupFor*

Most importantly, wait for the user settings to be loaded.
Comment 2 Ray Strode [halfline] 2017-10-31 16:51:16 UTC 
Created attachment 362649 [details] [review]
session: don't call gdm_session_defaults_changed from setup

It's only needed to update the session type, which we do
earlier in the function anyway.
Comment 3 Jan Alexander Steffens (heftig) 2017-10-31 16:53:46 UTC 
Created attachment 362650 [details] [review]
[PATCH] session-worker: Use g_variant_dup_string where possible

Just a bit of cleanup.
Comment 4 Ray Strode [halfline] 2017-10-31 17:15:12 UTC 
Attachment 362648 [details] pushed as e3f731c - session-worker: Adjust Initialize to behave more like SetupFor*
Attachment 362649 [details] pushed as b7720c2 - session: don't call gdm_session_defaults_changed from setup
Attachment 362650 [details] pushed as f59694d - session-worker: Use g_variant_dup_string where possible
Comment 5 Jan Alexander Steffens (heftig) 2017-10-31 17:23:51 UTC 
Created attachment 362660 [details]
Log excerpt: Failed gnome-xorg session
Comment 6 Jan Alexander Steffens (heftig) 2017-10-31 17:24:19 UTC 
Created attachment 362661 [details]
Log excerpt: Successful gnome-xorg session with the Initialize patch
Comment 7 Chad Rodrigue 2017-11-01 20:41:37 UTC 
*** Bug 789720 has been marked as a duplicate of this bug. ***